Skip to content

feat: 프록시 삭제 #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hwangdae merged 10 commits into from
Nov 7, 2025
Merged

feat: 프록시 삭제 #519

hwangdae merged 10 commits into from
Nov 7, 2025

Conversation

@hwangdae
Copy link
Collaborator

@hwangdae hwangdae commented Nov 7, 2025 •
edited by coderabbitai bot
Loading

작업 내용

문제점 및 어려움

해결 방안

공유 사항

Summary by CodeRabbit

Release Notes

  • New Features

    • Added router history tracking functionality to enhance navigation experience.

  • Bug Fixes

    • Improved IME composition handling for menu input fields to prevent unintended character removal during international text input.
    • Enhanced emoji removal logic to better support Hangul characters in menu names.

  • Refactor

    • Updated reservation API endpoints for improved consistency.
    • Streamlined API configuration for better URL handling.

dgKim1 and others added 10 commits September 22, 2025 22:04
@github-actions github-actions bot requested a review from oriNuguri25 November 7, 2025 10:09
@hwangdae hwangdae merged commit ddb8731 into main Nov 7, 2025
2 checks passed
@coderabbitai
Copy link

coderabbitai bot commented Nov 7, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The PR refactors reservation identification parameters from userId to reservationNumber in the admin app's reservation hooks and pages, improves IME composition handling in menu input fields to prevent emoji stripping mid-composition, updates emoji sanitization regex patterns to include Hangul jamo characters, configures axios base URL using an API_URI constant in the user app, introduces a new router history tracking hook, and removes two rewrite rules from vercel.json deployment configuration.

Changes

Cohort / File(s) Summary
Admin reservation parameter refactoring
apps/nowait-admin/src/hooks/Reservation/useUpdateReservationStatus.tsx, apps/nowait-admin/src/pages/AdminHome/AdminHome.tsx		 Parameter renamed from userId to reservationNumber in UpdateReservationParams interface, mutation function, and API endpoint construction. AdminHome handlers (handleCall, handleEnter, handleClose) updated to accept and pass reservationNumber instead of userId.
Admin menu input handling
apps/nowait-admin/src/hooks/useRemoveEmoji.tsx, apps/nowait-admin/src/pages/AdminBooth/components/Modal/menuModal.tsx		 Emoji sanitization regex patterns expanded to include Hangul jamo range (ㅏ-ㅣ) and parentheses/brackets grouping. MenuModal adds IME composition state tracking (isComposingName, isComposingAdmin) to conditionally apply emoji removal only after composition ends, preventing mid-composition stripping.
Build and configuration
apps/nowait-admin/tsconfig.app.tsbuildinfo		 TypeScript build info regenerated with updated source file set including NewOrderToast.tsx, useDetectNewOrders.tsx, useNewOrderToastStore.tsx, ImageCropModal.tsx, and Booth/type/booth.ts.
User API configuration
apps/nowait-user/src/api/order.ts		 API_URI constant introduced from VITE_SERVER_URI and set as axios baseURL. getStorePayments updated to use full URL with API_URI instead of relative path.
User routing and deployment
apps/nowait-user/src/hooks/useRouterHistory.ts, apps/nowait-user/vercel.json		 New useRouterHistory hook added to track router navigation history using useState and useLocation. Two rewrite rules removed from vercel.json: "/orders/:path*" and "/v1/:path*" redirects to nowait.co.kr.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • AdminHome.tsx: Multiple handler signature updates with semantic mismatch flagged—second argument remains res.userId but handlers now expect reservationNumber, requiring careful verification that the mapping is intentional.
  • menuModal.tsx: IME composition state logic requires testing across different input methods to ensure emoji removal works correctly without interfering with input composition.
  • useRemoveEmoji.tsx: Regex pattern changes need validation to confirm Hangul jamo inclusion and bracket grouping behave as intended for menu sanitization.
  • API configuration changes: Verify baseURL configuration doesn't inadvertently affect existing relative path requests or error handling.

Possibly related PRs

  • develop 변경사항 main으로 병합 #254: Direct overlap with admin reservation parameter refactoring and menuModal IME composition handling across the same files.
  • merge to main #378: Modifies axios baseURL configuration in apps/nowait-user/src/api/order.ts with related API_URI changes.
  • Develop #355: Related to vercel.json rewrite rule modifications in deployment configuration.

Suggested reviewers

  • dgKim1

Poem

🐰 With emojis preserved mid-compose,
And reservations renamed with care,
The admin flows smoothly, no longer a loss,
While history traces paths through the air. ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ae830e2 and 440a23c.

⛔ Files ignored due to path filters (17)
  • apps/nowait-admin/dist/assets/banner-BZOeI9vB.svg is excluded by !**/dist/**, !**/*.svg
  • apps/nowait-admin/dist/assets/bg_festival-CYbdk6eS.svg is excluded by !**/dist/**, !**/*.svg
  • apps/nowait-admin/dist/assets/bg_order-C4LFRYk8.svg is excluded by !**/dist/**, !**/*.svg
  • apps/nowait-admin/dist/assets/bg_status-X4xZSgun.svg is excluded by !**/dist/**, !**/*.svg
  • apps/nowait-admin/dist/assets/bg_waiting-B0UxGpnI.svg is excluded by !**/dist/**, !**/*.svg
  • apps/nowait-admin/dist/assets/index-BygJeh2Q.js is excluded by !**/dist/**
  • apps/nowait-admin/dist/assets/index-C0RRDTKc.css is excluded by !**/dist/**
  • apps/nowait-admin/dist/assets/index-CceQ--ur.css is excluded by !**/dist/**
  • apps/nowait-admin/dist/assets/index-DW0XV7o7.js is excluded by !**/dist/**
  • apps/nowait-admin/dist/assets/index-LjFDaPMN.css is excluded by !**/dist/**
  • apps/nowait-admin/dist/assets/kakao-8XdR8U-n.png is excluded by !**/dist/**, !**/*.png
  • apps/nowait-admin/dist/assets/kakaoLogo-C3ppN5vA.svg is excluded by !**/dist/**, !**/*.svg
  • apps/nowait-admin/dist/assets/toss-CibZHcza.png is excluded by !**/dist/**, !**/*.png
  • apps/nowait-admin/dist/assets/tossLogo-BDXEA9g6.svg is excluded by !**/dist/**, !**/*.svg
  • apps/nowait-admin/dist/assets/underline-Bqk3dE8x.svg is excluded by !**/dist/**, !**/*.svg
  • apps/nowait-admin/dist/index.html is excluded by !**/dist/**
  • packages/ui/dist/index.css is excluded by !**/dist/**
📒 Files selected for processing (8)
  • apps/nowait-admin/src/hooks/Reservation/useUpdateReservationStatus.tsx (1 hunks)
  • apps/nowait-admin/src/hooks/useRemoveEmoji.tsx (1 hunks)
  • apps/nowait-admin/src/pages/AdminBooth/components/Modal/menuModal.tsx (3 hunks)
  • apps/nowait-admin/src/pages/AdminHome/AdminHome.tsx (3 hunks)
  • apps/nowait-admin/tsconfig.app.tsbuildinfo (1 hunks)
  • apps/nowait-user/src/api/order.ts (1 hunks)
  • apps/nowait-user/src/hooks/useRouterHistory.ts (1 hunks)
  • apps/nowait-user/vercel.json (0 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oriNuguri25 oriNuguri25 Awaiting requested review from oriNuguri25

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hwangdae @dgKim1